projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8e55ea1
)
ASoC: SOF: Intel: lower print level to dbg if we will reinit DSP
author
Bard liao
<yung-chuan.liao@linux.intel.com>
Fri, 10 Jan 2020 23:57:48 +0000
(17:57 -0600)
committer
Mark Brown
<broonie@kernel.org>
Mon, 13 Jan 2020 15:12:22 +0000
(15:12 +0000)
We will reinit DSP in a loop when it fails to initialize the first
time, as recommended. So, it is not an error before we finally give
up. And reorder the trace to make it more readable.
Signed-off-by: Bard liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link:
https://lore.kernel.org/r/20200110235751.3404-6-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/intel/hda-loader.c
patch
|
blob
|
history
diff --git
a/sound/soc/sof/intel/hda-loader.c
b/sound/soc/sof/intel/hda-loader.c
index
b178336
..
bae7ac3
100644
(file)
--- a/
sound/soc/sof/intel/hda-loader.c
+++ b/
sound/soc/sof/intel/hda-loader.c
@@
-329,13
+329,13
@@
int hda_dsp_cl_boot_firmware(struct snd_sof_dev *sdev)
if (!ret)
break;
- dev_err(sdev->dev, "error: Error code=0x%x: FW status=0x%x\n",
+ dev_dbg(sdev->dev, "iteration %d of Core En/ROM load failed: %d\n",
+ i, ret);
+ dev_dbg(sdev->dev, "Error code=0x%x: FW status=0x%x\n",
snd_sof_dsp_read(sdev, HDA_DSP_BAR,
HDA_DSP_SRAM_REG_ROM_ERROR),
snd_sof_dsp_read(sdev, HDA_DSP_BAR,
HDA_DSP_SRAM_REG_ROM_STATUS));
- dev_err(sdev->dev, "error: iteration %d of Core En/ROM load failed: %d\n",
- i, ret);
}
if (i == HDA_FW_BOOT_ATTEMPTS) {