LF-2856 media: ipu: Fix Coverity Issue: 17672 Dereference before null check
authorRobby Cai <robby.cai@nxp.com>
Fri, 7 May 2021 09:57:17 +0000 (17:57 +0800)
committerRobby Cai <robby.cai@nxp.com>
Mon, 10 May 2021 03:44:53 +0000 (11:44 +0800)
Fixed dereference before NULL check issue

Signed-off-by: Robby Cai <robby.cai@nxp.com>
Reviewed-by: G.n. Zhou <guoniu.zhou@nxp.com>
drivers/media/platform/mxc/capture/ipu_still.c

index 4930e79..4432cb3 100644 (file)
@@ -224,9 +224,9 @@ int prp_still_deselect(void *private)
        cam_data *cam = (cam_data *) private;
        int err = 0;
 
-       err = prp_still_stop(cam);
-
        if (cam) {
+               err = prp_still_stop(cam);
+
                cam->csi_start = NULL;
                cam->csi_stop = NULL;
        }