LF-2861 media: mx6s_capture: Fix Coverity Issue: 17695 Dereference before null check
authorRobby Cai <robby.cai@nxp.com>
Fri, 7 May 2021 10:11:51 +0000 (18:11 +0800)
committerRobby Cai <robby.cai@nxp.com>
Mon, 10 May 2021 03:46:28 +0000 (11:46 +0800)
Fix dereference before NULL check issue

Signed-off-by: Robby Cai <robby.cai@nxp.com>
Reviewed-by: G.n. Zhou <guoniu.zhou@nxp.com>
drivers/media/platform/mxc/capture/mx6s_capture.c

index 1fe51c3..433f2d1 100644 (file)
@@ -1711,13 +1711,13 @@ static int subdev_notifier_bound(struct v4l2_async_notifier *notifier,
 {
        struct mx6s_csi_dev *csi_dev = notifier_to_mx6s_dev(notifier);
 
+       if (subdev == NULL)
+               return -EINVAL;
+
        /* Find platform data for this sensor subdev */
        if (csi_dev->asd.match.fwnode == dev_fwnode(subdev->dev))
                csi_dev->sd = subdev;
 
-       if (subdev == NULL)
-               return -EINVAL;
-
        v4l2_info(&csi_dev->v4l2_dev, "Registered sensor subdevice: %s\n",
                  subdev->name);