LF-2859 media: mxc_capture: Fix Coverity Issue: 17678 Dereference before null check

Fix issue for dereference before NULL check

Signed-off-by: Robby Cai <robby.cai@nxp.com>
Reviewed-by: G.n. Zhou <guoniu.zhou@nxp.com>

diff --git a/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c b/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c
index b9dae9b..7256565 100644 (file)
--- a/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c
+++ b/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c
@@ -133,7 +133,7 @@ static int csi_enc_setup(cam_data *cam)
 {
        ipu_channel_params_t params;
        int err = 0, sensor_protocol = 0;
-       ipu_channel_t chan = (cam->csi == 0) ? CSI_MEM0 : CSI_MEM1;
+       ipu_channel_t chan;
 #ifdef CONFIG_MXC_MIPI_CSI2
        void *mipi_csi2_info;
        int ipu_id;
@@ -145,6 +145,7 @@ static int csi_enc_setup(cam_data *cam)
                printk(KERN_ERR "cam private is NULL\n");
                return -ENXIO;
        }
+       chan = (cam->csi == 0) ? CSI_MEM0 : CSI_MEM1;
 
        memset(&params, 0, sizeof(ipu_channel_params_t));
        params.csi_mem.csi = cam->csi;