brcmfmac: remove unnecessary call to brcmf_sdiod_set_backplane_window()
authorIan Molton <ian@mnementh.co.uk>
Fri, 8 Dec 2017 12:10:32 +0000 (13:10 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 14 Dec 2017 12:41:02 +0000 (14:41 +0200)
All functions that might require the window address changing call
brcmf_sdiod_set_backplane_window() prior to access. Thus resetting
the window is not required.

Signed-off-by: Ian Molton <ian@mnementh.co.uk>
[arend: corrected the driver prefix in the subject]
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c

index 5fcd193..f8b47c1 100644 (file)
@@ -723,11 +723,6 @@ brcmf_sdiod_ramrw(struct brcmf_sdio_dev *sdiodev, bool write, u32 address,
 
        dev_kfree_skb(pkt);
 
-       /* Return the window to backplane enumeration space for core access */
-       if (brcmf_sdiod_set_backplane_window(sdiodev, sdiodev->sbwad))
-               brcmf_err("FAILED to set window back to 0x%x\n",
-                         sdiodev->sbwad);
-
        sdio_release_host(sdiodev->func[1]);
 
        return err;