xfs: remove unnecessary arguments from quota adjust functions
authorDarrick J. Wong <darrick.wong@oracle.com>
Tue, 14 Jul 2020 17:37:33 +0000 (10:37 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Wed, 29 Jul 2020 03:24:14 +0000 (20:24 -0700)
struct xfs_dquot already has a pointer to the xfs mount, so remove the
redundant parameter from xfs_qm_adjust_dq*.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
fs/xfs/xfs_dquot.c
fs/xfs/xfs_dquot.h
fs/xfs/xfs_qm.c
fs/xfs/xfs_qm_syscalls.c
fs/xfs/xfs_trans_dquot.c

index 1827a10..c09d925 100644 (file)
@@ -67,9 +67,9 @@ xfs_qm_dqdestroy(
  */
 void
 xfs_qm_adjust_dqlimits(
-       struct xfs_mount        *mp,
        struct xfs_dquot        *dq)
 {
+       struct xfs_mount        *mp = dq->q_mount;
        struct xfs_quotainfo    *q = mp->m_quotainfo;
        struct xfs_def_quota    *defq;
        int                     prealloc = 0;
@@ -113,9 +113,9 @@ xfs_qm_adjust_dqlimits(
  */
 void
 xfs_qm_adjust_dqtimers(
-       struct xfs_mount        *mp,
        struct xfs_dquot        *dq)
 {
+       struct xfs_mount        *mp = dq->q_mount;
        struct xfs_quotainfo    *qi = mp->m_quotainfo;
        struct xfs_def_quota    *defq;
 
index 48fb0f2..9e44da5 100644 (file)
@@ -182,11 +182,10 @@ void xfs_dquot_to_disk(struct xfs_disk_dquot *ddqp, struct xfs_dquot *dqp);
 void           xfs_qm_dqdestroy(struct xfs_dquot *dqp);
 int            xfs_qm_dqflush(struct xfs_dquot *dqp, struct xfs_buf **bpp);
 void           xfs_qm_dqunpin_wait(struct xfs_dquot *dqp);
-void           xfs_qm_adjust_dqtimers(struct xfs_mount *mp,
-                                               struct xfs_dquot *d);
-void           xfs_qm_adjust_dqlimits(struct xfs_mount *mp,
-                                               struct xfs_dquot *d);
-xfs_dqid_t     xfs_qm_id_for_quotatype(struct xfs_inode *ip, uint type);
+void           xfs_qm_adjust_dqtimers(struct xfs_dquot *d);
+void           xfs_qm_adjust_dqlimits(struct xfs_dquot *d);
+xfs_dqid_t     xfs_qm_id_for_quotatype(struct xfs_inode *ip,
+                               uint type);
 int            xfs_qm_dqget(struct xfs_mount *mp, xfs_dqid_t id,
                                        uint type, bool can_alloc,
                                        struct xfs_dquot **dqpp);
index 8ab4dd4..7d83c16 100644 (file)
@@ -1103,8 +1103,8 @@ xfs_qm_quotacheck_dqadjust(
         * There are no timers for the default values set in the root dquot.
         */
        if (dqp->q_id) {
-               xfs_qm_adjust_dqlimits(mp, dqp);
-               xfs_qm_adjust_dqtimers(mp, dqp);
+               xfs_qm_adjust_dqlimits(dqp);
+               xfs_qm_adjust_dqtimers(dqp);
        }
 
        dqp->q_flags |= XFS_DQFLAG_DIRTY;
index 51941c1..aeea59d 100644 (file)
@@ -594,7 +594,7 @@ xfs_qm_scall_setqlim(
                 * is on or off. We don't really want to bother with iterating
                 * over all ondisk dquots and turning the timers on/off.
                 */
-               xfs_qm_adjust_dqtimers(mp, dqp);
+               xfs_qm_adjust_dqtimers(dqp);
        }
        dqp->q_flags |= XFS_DQFLAG_DIRTY;
        xfs_trans_log_dquot(tp, dqp);
index 9adea8f..6f0bfd5 100644 (file)
@@ -382,8 +382,8 @@ xfs_trans_apply_dquot_deltas(
                         * Start/reset the timer(s) if needed.
                         */
                        if (dqp->q_id) {
-                               xfs_qm_adjust_dqlimits(tp->t_mountp, dqp);
-                               xfs_qm_adjust_dqtimers(tp->t_mountp, dqp);
+                               xfs_qm_adjust_dqlimits(dqp);
+                               xfs_qm_adjust_dqtimers(dqp);
                        }
 
                        dqp->q_flags |= XFS_DQFLAG_DIRTY;