gpu: ipu-v3: pre: fix device node leak in ipu_pre_lookup_by_phandle
authorTobias Jordan <Tobias.Jordan@elektrobit.com>
Thu, 15 Feb 2018 14:34:55 +0000 (15:34 +0100)
committerPhilipp Zabel <p.zabel@pengutronix.de>
Mon, 19 Feb 2018 14:12:59 +0000 (15:12 +0100)
Before returning, call of_node_put() for the device node returned by
of_parse_phandle().

Fixes: d2a34232580a ("gpu: ipu-v3: add driver for Prefetch Resolve Engine")
Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
drivers/gpu/ipu-v3/ipu-pre.c

index f1cec3d..0f70e88 100644 (file)
@@ -129,11 +129,14 @@ ipu_pre_lookup_by_phandle(struct device *dev, const char *name, int index)
                if (pre_node == pre->dev->of_node) {
                        mutex_unlock(&ipu_pre_list_mutex);
                        device_link_add(dev, pre->dev, DL_FLAG_AUTOREMOVE);
+                       of_node_put(pre_node);
                        return pre;
                }
        }
        mutex_unlock(&ipu_pre_list_mutex);
 
+       of_node_put(pre_node);
+
        return NULL;
 }