irqchip/loongson-pch-msi: Use bitmap_zalloc() to allocate bitmap
authorHuacai Chen <chenhuacai@loongson.cn>
Tue, 9 Feb 2021 07:10:51 +0000 (15:10 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Mar 2021 10:38:42 +0000 (11:38 +0100)
commit c1f664d2400e73d5ca0fcd067fa5847d2c789c11 upstream.

Currently we use bitmap_alloc() to allocate msi bitmap which should be
initialized with zero. This is obviously wrong but it works because msi
can fallback to legacy interrupt mode. So use bitmap_zalloc() instead.

Fixes: 632dcc2c75ef6de3272aa ("irqchip: Add Loongson PCH MSI controller")
Cc: stable@vger.kernel.org
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210209071051.2078435-1-chenhuacai@loongson.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/irqchip/irq-loongson-pch-msi.c

index 12aeeab..32562b7 100644 (file)
@@ -225,7 +225,7 @@ static int pch_msi_init(struct device_node *node,
                goto err_priv;
        }
 
-       priv->msi_map = bitmap_alloc(priv->num_irqs, GFP_KERNEL);
+       priv->msi_map = bitmap_zalloc(priv->num_irqs, GFP_KERNEL);
        if (!priv->msi_map) {
                ret = -ENOMEM;
                goto err_priv;