mlxsw: spectrum_span: Use a more fitting error code
authorPetr Machata <petrm@mellanox.com>
Fri, 11 May 2018 08:57:31 +0000 (11:57 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 11 May 2018 20:01:24 +0000 (16:01 -0400)
ENOENT is suitable when an item is looked for in a collection and can't
be found. The failure here is actually a depletion of a resource, where
ENOBUFS is the more fitting error code.

Signed-off-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c

index adf1f78..e5f4f76 100644 (file)
@@ -924,7 +924,7 @@ int mlxsw_sp_span_mirror_add(struct mlxsw_sp_port *from,
 
        span_entry = mlxsw_sp_span_entry_get(mlxsw_sp, to_dev, ops, sparms);
        if (!span_entry)
-               return -ENOENT;
+               return -ENOBUFS;
 
        netdev_dbg(from->dev, "Adding inspected port to SPAN entry %d\n",
                   span_entry->id);