MLK-11479-08 ASoC: fsl: Drop snd_soc_dapm_sync() in imx-wm8962
authorNicolin Chen <b42378@freescale.com>
Fri, 29 Nov 2013 09:44:39 +0000 (17:44 +0800)
committerNitin Garg <nitin.garg@nxp.com>
Mon, 19 Mar 2018 19:48:21 +0000 (14:48 -0500)
cherry-pick below patch from v3.14.y:
ENGR00290229 ASoC: fsl: Drop snd_soc_dapm_sync() in imx-wm8962

As DAPM would do the sync() for us, we don't need to handle it by ourselves.
And leaving snd_soc_dapm_sync() here is dangerous because it would disable
the clock from WM8962 during the short period of the output route changing
since we don't leave the alternative route's enanbling to this machine driver
but to DAPM core.

Acked-by: Wang Shengjiu <b02247@freescale.com>
Signed-off-by: Nicolin Chen <b42378@freescale.com>
(cherry picked from commit c4dcde0b5119262cbb75c5136422af2071bffbda)

sound/soc/fsl/imx-wm8962.c

index fad7c95..b53e99b 100644 (file)
@@ -108,7 +108,6 @@ static int hpjack_status_check(void *data)
                snd_soc_dapm_enable_pin(snd_soc_codec_get_dapm(priv->codec), "Ext Spk");
                ret = 0;
        }
-       snd_soc_dapm_sync(&priv->codec->dapm);
 
        envp[0] = "NAME=headphone";
        envp[1] = buf;
@@ -154,7 +153,6 @@ static int micjack_status_check(void *data)
                snd_soc_dapm_enable_pin(snd_soc_codec_get_dapm(priv->codec), "DMIC");
                ret = 0;
        }
-       snd_soc_dapm_sync(&priv->codec->dapm);
 
        envp[0] = "NAME=microphone";
        envp[1] = buf;