MLK-17459-4: drm: imx: dcss: fix weston
authorLaurentiu Palcu <laurentiu.palcu@nxp.com>
Fri, 23 Feb 2018 10:39:22 +0000 (12:39 +0200)
committerLeonard Crestez <leonard.crestez@nxp.com>
Wed, 17 Apr 2019 23:51:34 +0000 (02:51 +0300)
This patch fixes an issue introduced by the cropping patches which made
weston look bad. That's because use_dtrc flag was enabled if modifiers
were present. However, graphics plane can have modifiers too. This patch
adds an extra check.

Also, remove an unnecessary debug message.

Signed-off-by: Laurentiu Palcu <laurentiu.palcu@nxp.com>
drivers/gpu/imx/dcss/dcss-dpr.c

index 3afd5b2..b3639cf 100644 (file)
@@ -617,13 +617,11 @@ void dcss_dpr_format_set(struct dcss_soc *dcss, int ch_num, u32 pix_format,
        struct drm_format_name_buf format_name;
        enum dcss_color_space dcss_cs;
 
-       dev_dbg(dcss->dev, "%s\n", __func__);
-
        dcss_cs = dcss_drm_fourcc_to_colorspace(pix_format);
        ch->planes = drm_format_num_planes(pix_format);
        ch->bpp = dcss_dpr_get_bpp(pix_format);
        ch->pix_format = pix_format;
-       ch->use_dtrc = modifiers_present;
+       ch->use_dtrc = ch_num && modifiers_present;
 
        dev_dbg(dcss->dev, "pix_format = %s, colorspace = %d, bpp = %d\n",
                drm_get_format_name(pix_format, &format_name), dcss_cs, ch->bpp);