ASoC: davinci: Kill BUG_ON() usage

Don't use BUG_ON() for a non-critical sanity check on production
systems.  This patch replaces with a softer WARN_ON() and an error
path.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
index 23b0da7..40be08c 100644 (file)
--- a/sound/soc/davinci/davinci-mcasp.c
+++ b/sound/soc/davinci/davinci-mcasp.c
@@ -1721,7 +1721,8 @@ static int davinci_mcasp_get_dma_type(struct davinci_mcasp *mcasp)
                                PTR_ERR(chan));
                return PTR_ERR(chan);
        }
-       BUG_ON(!chan->device || !chan->device->dev);
+       if (WARN_ON(!chan->device || !chan->device->dev))
+               return -EINVAL;
 
        if (chan->device->dev->of_node)
                ret = of_property_read_string(chan->device->dev->of_node,