projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
1bd7b0f
)
ASoC: qcom: lpass-platform: Fix memory leak
author
Srinivasa Rao Mandadapu
<srivasam@codeaurora.org>
Sun, 15 Nov 2020 04:56:50 +0000
(10:26 +0530)
committer
Mark Brown
<broonie@kernel.org>
Mon, 16 Nov 2020 20:02:41 +0000
(20:02 +0000)
lpass_pcm_data is not freed in error paths. Free it in
error paths to avoid memory leak.
Fixes:
022d00ee0b55
("ASoC: lpass-platform: Fix broken pcm data usage")
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
Link:
https://lore.kernel.org/r/1605416210-14530-1-git-send-email-srivasam@codeaurora.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/lpass-platform.c
patch
|
blob
|
history
diff --git
a/sound/soc/qcom/lpass-platform.c
b/sound/soc/qcom/lpass-platform.c
index
36d1512
..
7a3fdf8
100644
(file)
--- a/
sound/soc/qcom/lpass-platform.c
+++ b/
sound/soc/qcom/lpass-platform.c
@@
-122,8
+122,10
@@
static int lpass_platform_pcmops_open(struct snd_soc_component *component,
else
dma_ch = 0;
- if (dma_ch < 0)
+ if (dma_ch < 0) {
+ kfree(data);
return dma_ch;
+ }
if (cpu_dai->driver->id == LPASS_DP_RX) {
map = drvdata->hdmiif_map;
@@
-147,6
+149,7
@@
static int lpass_platform_pcmops_open(struct snd_soc_component *component,
ret = snd_pcm_hw_constraint_integer(runtime,
SNDRV_PCM_HW_PARAM_PERIODS);
if (ret < 0) {
+ kfree(data);
dev_err(soc_runtime->dev, "setting constraints failed: %d\n",
ret);
return -EINVAL;