scsi: sym53c8xx_2: Delete unnecessary else-if in sym_xerr_cam_status()
authorYe Bin <yebin10@huawei.com>
Wed, 2 Sep 2020 06:16:46 +0000 (14:16 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 16 Sep 2020 01:25:52 +0000 (21:25 -0400)
If (x_status & XE_PARITY_ERR) is true we set cam_status = DID_PARITY,
othervise cam_status always ends up being DID_ERROR. Delete superfluous
else-if statements.

Link: https://lore.kernel.org/r/20200902061646.576966-1-yebin10@huawei.com
Signed-off-by: Ye Bin <yebin10@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sym53c8xx_2/sym_glue.c

index 28edb6e..d9a045f 100644 (file)
@@ -156,12 +156,8 @@ void sym_xpt_async_bus_reset(struct sym_hcb *np)
 static int sym_xerr_cam_status(int cam_status, int x_status)
 {
        if (x_status) {
-               if      (x_status & XE_PARITY_ERR)
+               if (x_status & XE_PARITY_ERR)
                        cam_status = DID_PARITY;
-               else if (x_status &(XE_EXTRA_DATA|XE_SODL_UNRUN|XE_SWIDE_OVRUN))
-                       cam_status = DID_ERROR;
-               else if (x_status & XE_BAD_PHASE)
-                       cam_status = DID_ERROR;
                else
                        cam_status = DID_ERROR;
        }