crypto: ccree - fix retry handling in cc_send_sync_request()
authorGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 11 Feb 2020 18:18:57 +0000 (19:18 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 22 Feb 2020 01:25:43 +0000 (09:25 +0800)
If cc_queues_status() indicates that the queue is full,
cc_send_sync_request() should loop and retry.

However, cc_queues_status() returns either 0 (for success), or -ENOSPC
(for queue full), while cc_send_sync_request() checks for real errors by
comparing with -EAGAIN.  Hence -ENOSPC is always considered a real
error, and the code never retries the operation.

Fix this by just removing the check, as cc_queues_status() never returns
any other error value than -ENOSPC.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/ccree/cc_request_mgr.c

index 9d61e6f..b2a1812 100644 (file)
@@ -476,10 +476,6 @@ int cc_send_sync_request(struct cc_drvdata *drvdata,
                        break;
 
                spin_unlock_bh(&mgr->hw_lock);
-               if (rc != -EAGAIN) {
-                       cc_pm_put_suspend(dev);
-                       return rc;
-               }
                wait_for_completion_interruptible(&drvdata->hw_queue_avail);
                reinit_completion(&drvdata->hw_queue_avail);
        }