xfs: remove xfs_defer_reset

Remove this one-line helper since the assert is trivially true in one
call site and the rest obscures a bitmask operation.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>

diff --git a/fs/xfs/libxfs/xfs_defer.c b/fs/xfs/libxfs/xfs_defer.c
index 29e9762..36c103c 100644 (file)
--- a/fs/xfs/libxfs/xfs_defer.c
+++ b/fs/xfs/libxfs/xfs_defer.c
@@ -312,22 +312,6 @@ xfs_defer_trans_roll(
        return error;
 }
 
-/*
- * Reset an already used dfops after finish.
- */
-static void
-xfs_defer_reset(
-       struct xfs_trans        *tp)
-{
-       ASSERT(list_empty(&tp->t_dfops));
-
-       /*
-        * Low mode state transfers across transaction rolls to mirror dfops
-        * lifetime. Clear it now that dfops is reset.
-        */
-       tp->t_flags &= ~XFS_TRANS_LOWMODE;
-}
-
 /*
  * Free up any items left in the list.
  */
@@ -477,7 +461,10 @@ xfs_defer_finish(
                        return error;
                }
        }
-       xfs_defer_reset(*tp);
+
+       /* Reset LOWMODE now that we've finished all the dfops. */
+       ASSERT(list_empty(&(*tp)->t_dfops));
+       (*tp)->t_flags &= ~XFS_TRANS_LOWMODE;
        return 0;
 }
 
@@ -551,8 +538,7 @@ xfs_defer_move(
         * that behavior.
         */
        dtp->t_flags |= (stp->t_flags & XFS_TRANS_LOWMODE);
-
-       xfs_defer_reset(stp);
+       stp->t_flags &= ~XFS_TRANS_LOWMODE;
 }
 
 /*