projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
30da837
)
USB: legousbtower: drop redundant open_count check
author
Johan Hovold
<johan@kernel.org>
Tue, 5 Nov 2019 08:41:42 +0000
(09:41 +0100)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Thu, 7 Nov 2019 10:17:50 +0000
(11:17 +0100)
Drop redundant open_count check in release; the open count is used as a
flag and is only set to 0 or 1.
Signed-off-by: Johan Hovold <johan@kernel.org>
Link:
https://lore.kernel.org/r/20191105084152.16322-5-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/legousbtower.c
patch
|
blob
|
history
diff --git
a/drivers/usb/misc/legousbtower.c
b/drivers/usb/misc/legousbtower.c
index
c880d58
..
1626a0d
100644
(file)
--- a/
drivers/usb/misc/legousbtower.c
+++ b/
drivers/usb/misc/legousbtower.c
@@
-421,13
+421,6
@@
static int tower_release (struct inode *inode, struct file *file)
mutex_lock(&dev->lock);
- if (dev->open_count != 1) {
- dev_dbg(&dev->udev->dev, "%s: device not opened exactly once\n",
- __func__);
- retval = -ENODEV;
- goto unlock_exit;
- }
-
if (dev->disconnected) {
/* the device was unplugged before the file was released */
@@
-444,7
+437,6
@@
static int tower_release (struct inode *inode, struct file *file)
tower_abort_transfers (dev);
dev->open_count = 0;
-unlock_exit:
mutex_unlock(&dev->lock);
exit:
return retval;