tpm: declare struct tpm_header

Declare struct tpm_header that replaces struct tpm_input_header and
struct tpm_output_header.

Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Tested-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
Reviewed-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Tested-by: Alexander Steffen <Alexander.Steffen@infineon.com>

diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
index e48ed28..e0ed31c 100644 (file)
--- a/drivers/char/tpm/tpm-interface.c
+++ b/drivers/char/tpm/tpm-interface.c
@@ -62,12 +62,10 @@ unsigned long tpm_calc_ordinal_duration(struct tpm_chip *chip, u32 ordinal)
 }
 EXPORT_SYMBOL_GPL(tpm_calc_ordinal_duration);
 
-static int tpm_validate_command(struct tpm_chip *chip,
-                                struct tpm_space *space,
-                                const u8 *cmd,
-                                size_t len)
+static int tpm_validate_command(struct tpm_chip *chip, struct tpm_space *space,
+                               const void *cmd, size_t len)
 {
-       const struct tpm_input_header *header = (const void *)cmd;
+       const struct tpm_header *header = cmd;
        int i;
        u32 cc;
        u32 attrs;
@@ -161,12 +159,10 @@ static int tpm_go_idle(struct tpm_chip *chip, unsigned int flags)
        return chip->ops->go_idle(chip);
 }
 
-static ssize_t tpm_try_transmit(struct tpm_chip *chip,
-                               struct tpm_space *space,
-                               u8 *buf, size_t bufsiz,
-                               unsigned int flags)
+static ssize_t tpm_try_transmit(struct tpm_chip *chip, struct tpm_space *space,
+                               void *buf, size_t bufsiz, unsigned int flags)
 {
-       struct tpm_output_header *header = (void *)buf;
+       struct tpm_header *header = buf;
        int rc;
        ssize_t len = 0;
        u32 count, ordinal;
@@ -325,7 +321,7 @@ out_locality:
 ssize_t tpm_transmit(struct tpm_chip *chip, struct tpm_space *space,
                     u8 *buf, size_t bufsiz, unsigned int flags)
 {
-       struct tpm_output_header *header = (struct tpm_output_header *)buf;
+       struct tpm_header *header = (struct tpm_header *)buf;
        /* space for header and handles */
        u8 save[TPM_HEADER_SIZE + 3*sizeof(u32)];
        unsigned int delay_msec = TPM2_DURATION_SHORT;
@@ -390,8 +386,7 @@ ssize_t tpm_transmit_cmd(struct tpm_chip *chip, struct tpm_space *space,
                         struct tpm_buf *buf, size_t min_rsp_body_length,
                         unsigned int flags, const char *desc)
 {
-       const struct tpm_output_header *header =
-               (struct tpm_output_header *)buf->data;
+       const struct tpm_header *header = (struct tpm_header *)buf->data;
        int err;
        ssize_t len;
 

diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
index 49bca4d..1454ef1 100644 (file)
--- a/drivers/char/tpm/tpm.h
+++ b/drivers/char/tpm/tpm.h
@@ -273,16 +273,13 @@ struct tpm_chip {
 
 #define to_tpm_chip(d) container_of(d, struct tpm_chip, dev)
 
-struct tpm_input_header {
-       __be16  tag;
-       __be32  length;
-       __be32  ordinal;
-} __packed;
-
-struct tpm_output_header {
-       __be16  tag;
-       __be32  length;
-       __be32  return_code;
+struct tpm_header {
+       __be16 tag;
+       __be32 length;
+       union {
+               __be32 ordinal;
+               __be32 return_code;
+       };
 } __packed;
 
 #define TPM_TAG_RQU_COMMAND 193
@@ -401,8 +398,8 @@ struct tpm_buf {
 
 static inline void tpm_buf_reset(struct tpm_buf *buf, u16 tag, u32 ordinal)
 {
-       struct tpm_input_header *head;
-       head = (struct tpm_input_header *)buf->data;
+       struct tpm_header *head = (struct tpm_header *)buf->data;
+
        head->tag = cpu_to_be16(tag);
        head->length = cpu_to_be32(sizeof(*head));
        head->ordinal = cpu_to_be32(ordinal);
@@ -428,14 +425,14 @@ static inline void tpm_buf_destroy(struct tpm_buf *buf)
 
 static inline u32 tpm_buf_length(struct tpm_buf *buf)
 {
-       struct tpm_input_header *head = (struct tpm_input_header *) buf->data;
+       struct tpm_header *head = (struct tpm_header *)buf->data;
 
        return be32_to_cpu(head->length);
 }
 
 static inline u16 tpm_buf_tag(struct tpm_buf *buf)
 {
-       struct tpm_input_header *head = (struct tpm_input_header *) buf->data;
+       struct tpm_header *head = (struct tpm_header *)buf->data;
 
        return be16_to_cpu(head->tag);
 }
@@ -444,7 +441,7 @@ static inline void tpm_buf_append(struct tpm_buf *buf,
                                  const unsigned char *new_data,
                                  unsigned int new_len)
 {
-       struct tpm_input_header *head = (struct tpm_input_header *) buf->data;
+       struct tpm_header *head = (struct tpm_header *)buf->data;
        u32 len = tpm_buf_length(buf);
 
        /* Return silently if overflow has already happened. */
@@ -582,7 +579,7 @@ void tpm2_del_space(struct tpm_chip *chip, struct tpm_space *space);
 int tpm2_prepare_space(struct tpm_chip *chip, struct tpm_space *space, u32 cc,
                       u8 *cmd);
 int tpm2_commit_space(struct tpm_chip *chip, struct tpm_space *space,
-                     u32 cc, u8 *buf, size_t *bufsiz);
+                     u32 cc, void *buf, size_t *bufsiz);
 
 int tpm_bios_log_setup(struct tpm_chip *chip);
 void tpm_bios_log_teardown(struct tpm_chip *chip);

diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c
index 2bcf470..ab03f86 100644 (file)
--- a/drivers/char/tpm/tpm2-cmd.c
+++ b/drivers/char/tpm/tpm2-cmd.c
@@ -784,7 +784,7 @@ static int tpm2_do_selftest(struct tpm_chip *chip)
  */
 int tpm2_probe(struct tpm_chip *chip)
 {
-       struct tpm_output_header *out;
+       struct tpm_header *out;
        struct tpm_buf buf;
        int rc;
 
@@ -797,7 +797,7 @@ int tpm2_probe(struct tpm_chip *chip)
        rc = tpm_transmit_cmd(chip, NULL, &buf, 0, 0, NULL);
        /* We ignore TPM return codes on purpose. */
        if (rc >=  0) {
-               out = (struct tpm_output_header *)buf.data;
+               out = (struct tpm_header *)buf.data;
                if (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS)
                        chip->flags |= TPM_CHIP_FLAG_TPM2;
        }

diff --git a/drivers/char/tpm/tpm2-space.c b/drivers/char/tpm/tpm2-space.c
index 5ecc739..39cb391 100644 (file)
--- a/drivers/char/tpm/tpm2-space.c
+++ b/drivers/char/tpm/tpm2-space.c
@@ -334,7 +334,7 @@ static int tpm2_map_response_header(struct tpm_chip *chip, u32 cc, u8 *rsp,
                                    size_t len)
 {
        struct tpm_space *space = &chip->work_space;
-       struct tpm_output_header *header = (void *)rsp;
+       struct tpm_header *header = (struct tpm_header *)rsp;
        u32 phandle;
        u32 phandle_type;
        u32 vhandle;
@@ -394,7 +394,7 @@ static int tpm2_map_response_body(struct tpm_chip *chip, u32 cc, u8 *rsp,
                                  size_t len)
 {
        struct tpm_space *space = &chip->work_space;
-       struct tpm_output_header *header = (void *)rsp;
+       struct tpm_header *header = (struct tpm_header *)rsp;
        struct tpm2_cap_handles *data;
        u32 phandle;
        u32 phandle_type;
@@ -490,9 +490,9 @@ static int tpm2_save_space(struct tpm_chip *chip)
 }
 
 int tpm2_commit_space(struct tpm_chip *chip, struct tpm_space *space,
-                     u32 cc, u8 *buf, size_t *bufsiz)
+                     u32 cc, void *buf, size_t *bufsiz)
 {
-       struct tpm_output_header *header = (void *)buf;
+       struct tpm_header *header = buf;
        int rc;
 
        if (!space)

diff --git a/drivers/char/tpm/tpm_i2c_atmel.c b/drivers/char/tpm/tpm_i2c_atmel.c
index cc4e642..8a7e809 100644 (file)
--- a/drivers/char/tpm/tpm_i2c_atmel.c
+++ b/drivers/char/tpm/tpm_i2c_atmel.c
@@ -46,7 +46,7 @@ struct priv_data {
        /* This is the amount we read on the first try. 25 was chosen to fit a
         * fair number of read responses in the buffer so a 2nd retry can be
         * avoided in small message cases. */
-       u8 buffer[sizeof(struct tpm_output_header) + 25];
+       u8 buffer[sizeof(struct tpm_header) + 25];
 };
 
 static int i2c_atmel_send(struct tpm_chip *chip, u8 *buf, size_t len)
@@ -80,8 +80,7 @@ static int i2c_atmel_recv(struct tpm_chip *chip, u8 *buf, size_t count)
 {
        struct priv_data *priv = dev_get_drvdata(&chip->dev);
        struct i2c_client *client = to_i2c_client(chip->dev.parent);
-       struct tpm_output_header *hdr =
-               (struct tpm_output_header *)priv->buffer;
+       struct tpm_header *hdr = (struct tpm_header *)priv->buffer;
        u32 expected_len;
        int rc;
 

diff --git a/drivers/char/tpm/tpm_vtpm_proxy.c b/drivers/char/tpm/tpm_vtpm_proxy.c
index ed9a163..986d7e8 100644 (file)
--- a/drivers/char/tpm/tpm_vtpm_proxy.c
+++ b/drivers/char/tpm/tpm_vtpm_proxy.c
@@ -303,9 +303,9 @@ out:
 static int vtpm_proxy_is_driver_command(struct tpm_chip *chip,
                                        u8 *buf, size_t count)
 {
-       struct tpm_input_header *hdr = (struct tpm_input_header *)buf;
+       struct tpm_header *hdr = (struct tpm_header *)buf;
 
-       if (count < sizeof(struct tpm_input_header))
+       if (count < sizeof(struct tpm_header))
                return 0;
 
        if (chip->flags & TPM_CHIP_FLAG_TPM2) {
@@ -401,7 +401,7 @@ static int vtpm_proxy_request_locality(struct tpm_chip *chip, int locality)
 {
        struct tpm_buf buf;
        int rc;
-       const struct tpm_output_header *header;
+       const struct tpm_header *header;
        struct proxy_dev *proxy_dev = dev_get_drvdata(&chip->dev);
 
        if (chip->flags & TPM_CHIP_FLAG_TPM2)
@@ -426,7 +426,7 @@ static int vtpm_proxy_request_locality(struct tpm_chip *chip, int locality)
                goto out;
        }
 
-       header = (const struct tpm_output_header *)buf.data;
+       header = (const struct tpm_header *)buf.data;
        rc = be32_to_cpu(header->return_code);
        if (rc)
                locality = -1;

diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
index 5a327eb..4e2d00c 100644 (file)
--- a/drivers/char/tpm/xen-tpmfront.c
+++ b/drivers/char/tpm/xen-tpmfront.c
@@ -163,7 +163,7 @@ static int vtpm_send(struct tpm_chip *chip, u8 *buf, size_t count)
        wmb();
        notify_remote_via_evtchn(priv->evtchn);
 
-       ordinal = be32_to_cpu(((struct tpm_input_header*)buf)->ordinal);
+       ordinal = be32_to_cpu(((struct tpm_header *)buf)->ordinal);
        duration = tpm_calc_ordinal_duration(chip, ordinal);
 
        if (wait_for_tpm_stat(chip, VTPM_STATUS_IDLE, duration,