projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
239552f
)
hwmon: (core) Explain why at least two attribute groups are allocated
author
Guenter Roeck
<linux@roeck-us.net>
Mon, 17 Oct 2016 00:11:52 +0000
(17:11 -0700)
committer
Guenter Roeck
<linux@roeck-us.net>
Sat, 10 Dec 2016 05:54:21 +0000
(21:54 -0800)
A list of sysfs attribute groups is NULL-terminated, so we always need
to allocate data for at least two groups (the dynamically generated group
plus the NULL pointer). Add a comment to explain the situation.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/hwmon.c
patch
|
blob
|
history
diff --git
a/drivers/hwmon/hwmon.c
b/drivers/hwmon/hwmon.c
index
a0b5bec
..
8dc0466
100644
(file)
--- a/
drivers/hwmon/hwmon.c
+++ b/
drivers/hwmon/hwmon.c
@@
-561,7
+561,7
@@
__hwmon_device_register(struct device *dev, const char *name, void *drvdata,
if (chip) {
struct attribute **attrs;
- int ngroups = 2;
+ int ngroups = 2;
/* terminating NULL plus &hwdev->groups */
if (groups)
for (i = 0; groups[i]; i++)