drm/gma500: Add missing call to allow enabling vblank on psb/cdv
authorPaul Kocialkowski <paul.kocialkowski@bootlin.com>
Wed, 6 Nov 2019 09:43:59 +0000 (10:43 +0100)
committerPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
Thu, 7 Nov 2019 09:16:30 +0000 (10:16 +0100)
This adds a missing call to drm_crtc_vblank_on to the common DPMS helper
(used by poulsbo and cedartrail), which is called in the CRTC enable path.

With that call, it becomes possible to enable vblank when needed.
It is already balanced by a drm_crtc_vblank_off call in the helper.

Other platforms (oaktrail and medfield) use a dedicated DPMS helper that
does not have the proper vblank on/off hooks. They are not added in this
commit due to lack of hardware to test it with.

Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Reviewed-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191106094400.445834-2-paul.kocialkowski@bootlin.com
drivers/gpu/drm/gma500/gma_display.c

index e20ccb5..bc07ae2 100644 (file)
@@ -255,6 +255,8 @@ void gma_crtc_dpms(struct drm_crtc *crtc, int mode)
                /* Give the overlay scaler a chance to enable
                 * if it's on this pipe */
                /* psb_intel_crtc_dpms_video(crtc, true); TODO */
+
+               drm_crtc_vblank_on(crtc);
                break;
        case DRM_MODE_DPMS_OFF:
                if (!gma_crtc->active)