drm/panfrost: Show stored feature registers
authorRobin Murphy <robin.murphy@arm.com>
Fri, 3 May 2019 15:31:45 +0000 (16:31 +0100)
committerRob Herring <robh@kernel.org>
Fri, 3 May 2019 20:36:23 +0000 (15:36 -0500)
Re-reading the feature registers for the sake of displaying the raw
values seems pointless, and in fact showing the copies that we've
already read and stored is arguably more useful in terms of giving
exposure to any potential bugs in that part of the process.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/ce5e414adb008baeed9e2ceb9c88f28d5c74ea42.1556195258.git.robin.murphy@arm.com
drivers/gpu/drm/panfrost/panfrost_gpu.c

index 42511fc..58ef255 100644 (file)
@@ -278,13 +278,13 @@ static void panfrost_gpu_init_features(struct panfrost_device *pfdev)
                 pfdev->features.hw_issues);
 
        dev_info(pfdev->dev, "Features: L2:0x%08x Shader:0x%08x Tiler:0x%08x Mem:0x%0x MMU:0x%08x AS:0x%x JS:0x%x",
-                gpu_read(pfdev, GPU_L2_FEATURES),
-                gpu_read(pfdev, GPU_CORE_FEATURES),
-                gpu_read(pfdev, GPU_TILER_FEATURES),
-                gpu_read(pfdev, GPU_MEM_FEATURES),
-                gpu_read(pfdev, GPU_MMU_FEATURES),
-                gpu_read(pfdev, GPU_AS_PRESENT),
-                gpu_read(pfdev, GPU_JS_PRESENT));
+                pfdev->features.l2_features,
+                pfdev->features.core_features,
+                pfdev->features.tiler_features,
+                pfdev->features.mem_features,
+                pfdev->features.mmu_features,
+                pfdev->features.as_present,
+                pfdev->features.js_present);
 
        dev_info(pfdev->dev, "shader_present=0x%0llx l2_present=0x%0llx",
                 pfdev->features.shader_present, pfdev->features.l2_present);