MLK-11911-1 mxc IPUv3: capture: Define div_ratio as type of int32_t
authorLiu Ying <Ying.Liu@freescale.com>
Thu, 26 Nov 2015 07:28:36 +0000 (15:28 +0800)
committerNitin Garg <nitin.garg@nxp.com>
Mon, 19 Mar 2018 19:49:17 +0000 (14:49 -0500)
The local variable div_ratio could be less than zero, so let's define
it as type of int32_t instead of uint32_t.

This issue is reported by Coverity:
Unsigned compared against 0 (NO_EFFECT)
unsigned_compare: This less-than-zero comparison of an unsigned value
is never true. div_ratio < 0U.
if (div_ratio > 0xFF || div_ratio < 0) {
dev_dbg(ipu->dev, "value of pixel_clk extends normal range\n");
return -EINVAL;
}

Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
drivers/mxc/ipu3/ipu_capture.c

index 09bb6d9..f304c81 100644 (file)
@@ -43,7 +43,7 @@
 int _ipu_csi_mclk_set(struct ipu_soc *ipu, uint32_t pixel_clk, uint32_t csi)
 {
        uint32_t temp;
-       uint32_t div_ratio;
+       int32_t div_ratio;
 
        div_ratio = (clk_get_rate(ipu->ipu_clk) / pixel_clk) - 1;