driver core: Add missing annotation for device_links_read_lock()
authorJules Irenge <jbi.octave@gmail.com>
Fri, 14 Feb 2020 20:47:30 +0000 (20:47 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Mar 2020 18:15:20 +0000 (19:15 +0100)
Sparse reports a warning at device_links_read_unlock()

warning:  warning: context imbalance in device_links_read_unlock()
 - unexpected unlock

The root cause is the missing annotation at device_links_read_unlock()
Add the missing __releases(&device_links_srcu) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Link: https://lore.kernel.org/r/20200214204741.94112-20-jbi.octave@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/core.c

index 922680a..ae6804d 100644 (file)
@@ -69,7 +69,7 @@ int device_links_read_lock(void)
        return srcu_read_lock(&device_links_srcu);
 }
 
-void device_links_read_unlock(int idx)
+void device_links_read_unlock(int idx) __releases(&device_links_srcu)
 {
        srcu_read_unlock(&device_links_srcu, idx);
 }