MLK-12043: ASoC: fsl: imx-cs42888: Add return value check
authorShengjiu Wang <shengjiu.wang@freescale.com>
Tue, 22 Dec 2015 08:57:06 +0000 (16:57 +0800)
committerNitin Garg <nitin.garg@nxp.com>
Mon, 19 Mar 2018 19:49:33 +0000 (14:49 -0500)
Report by coverity (CID 18428). The return value need be checked
for snd_soc_dai_set_sysclk().

Signed-off-by: Shengjiu Wang <shengjiu.wang@freescale.com>
sound/soc/fsl/imx-cs42888.c

index 6817886..dea5a9a 100644 (file)
@@ -55,12 +55,22 @@ static int imx_cs42888_surround_hw_params(struct snd_pcm_substream *substream,
        dai_format = SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_NB_NF |
                     SND_SOC_DAIFMT_CBS_CFS;
        if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
-               snd_soc_dai_set_sysclk(cpu_dai, ESAI_HCKT_EXTAL,
+               ret = snd_soc_dai_set_sysclk(cpu_dai, ESAI_HCKT_EXTAL,
                               priv->mclk_freq, SND_SOC_CLOCK_OUT);
        else
-               snd_soc_dai_set_sysclk(cpu_dai, ESAI_HCKR_EXTAL,
+               ret = snd_soc_dai_set_sysclk(cpu_dai, ESAI_HCKR_EXTAL,
                               priv->mclk_freq, SND_SOC_CLOCK_OUT);
-       snd_soc_dai_set_sysclk(codec_dai, 0, priv->mclk_freq, SND_SOC_CLOCK_IN);
+       if (ret) {
+               dev_err(dev, "failed to set cpu sysclk: %d\n", ret);
+               return ret;
+       }
+
+       ret = snd_soc_dai_set_sysclk(codec_dai, 0,
+                               priv->mclk_freq, SND_SOC_CLOCK_IN);
+       if (ret) {
+               dev_err(dev, "failed to set codec sysclk: %d\n", ret);
+               return ret;
+       }
 
        /* set cpu DAI configuration */
        ret = snd_soc_dai_set_fmt(cpu_dai, dai_format);