iio: imu: inv_mpu6050: Drop double check for ACPI companion device
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 28 May 2020 14:15:52 +0000 (17:15 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 14 Jun 2020 10:49:32 +0000 (11:49 +0100)
acpi_dev_get_resources() does perform the NULL pointer check against
ACPI companion device which is given as function parameter. Thus,
there is no need to duplicate this check in the caller.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c

index c27d060..f8f0cf7 100644 (file)
@@ -101,8 +101,8 @@ static int inv_mpu_process_acpi_config(struct i2c_client *client,
                                       unsigned short *primary_addr,
                                       unsigned short *secondary_addr)
 {
+       struct acpi_device *adev = ACPI_COMPANION(&client->dev);
        const struct acpi_device_id *id;
-       struct acpi_device *adev;
        u32 i2c_addr = 0;
        LIST_HEAD(resources);
        int ret;
@@ -112,10 +112,6 @@ static int inv_mpu_process_acpi_config(struct i2c_client *client,
        if (!id)
                return -ENODEV;
 
-       adev = ACPI_COMPANION(&client->dev);
-       if (!adev)
-               return -ENODEV;
-
        ret = acpi_dev_get_resources(adev, &resources,
                                     acpi_i2c_check_resource, &i2c_addr);
        if (ret < 0)