nvmem: release the write-protect pin
authorKhouloud Touil <ktouil@baylibre.com>
Tue, 10 Mar 2020 13:22:50 +0000 (13:22 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Mar 2020 06:41:03 +0000 (07:41 +0100)
Put the write-protect GPIO descriptor in nvmem_release() so that it can
be automatically released when the associated device's reference count
drops to 0.

Fixes: 2a127da461a9 ("nvmem: add support for the write-protect pin")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Khouloud Touil <ktouil@baylibre.com>
Cc: stable <stable@vger.kernel.org>
[Bartosz: tweak the commit message]
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20200310132257.23358-8-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/nvmem/core.c

index 2758d90..c05c4f4 100644 (file)
@@ -72,6 +72,7 @@ static void nvmem_release(struct device *dev)
        struct nvmem_device *nvmem = to_nvmem_device(dev);
 
        ida_simple_remove(&nvmem_ida, nvmem->id);
+       gpiod_put(nvmem->wp_gpio);
        kfree(nvmem);
 }