sctp: pass a kernel pointer to sctp_setsockopt_recvrcvinfo

Use the kernel pointer that sctp_setsockopt has available instead of
directly handling the user pointer.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index ea027ea..ac56fb7 100644 (file)
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -3902,18 +3902,13 @@ static int sctp_setsockopt_paddr_thresholds(struct sock *sk,
        return 0;
 }
 
-static int sctp_setsockopt_recvrcvinfo(struct sock *sk,
-                                      char __user *optval,
+static int sctp_setsockopt_recvrcvinfo(struct sock *sk, int *val,
                                       unsigned int optlen)
 {
-       int val;
-
        if (optlen < sizeof(int))
                return -EINVAL;
-       if (get_user(val, (int __user *) optval))
-               return -EFAULT;
 
-       sctp_sk(sk)->recvrcvinfo = (val == 0) ? 0 : 1;
+       sctp_sk(sk)->recvrcvinfo = (*val == 0) ? 0 : 1;
 
        return 0;
 }
@@ -4695,7 +4690,7 @@ static int sctp_setsockopt(struct sock *sk, int level, int optname,
                                                          true);
                break;
        case SCTP_RECVRCVINFO:
-               retval = sctp_setsockopt_recvrcvinfo(sk, optval, optlen);
+               retval = sctp_setsockopt_recvrcvinfo(sk, kopt, optlen);
                break;
        case SCTP_RECVNXTINFO:
                retval = sctp_setsockopt_recvnxtinfo(sk, optval, optlen);