MLK-11932 video: fbdev: mxc: ldb: Do not touch fbi->modelist in ldb_init()
authorLiu Ying <Ying.Liu@freescale.com>
Tue, 1 Dec 2015 06:42:41 +0000 (14:42 +0800)
committerNitin Garg <nitin.garg@nxp.com>
Mon, 19 Mar 2018 19:49:20 +0000 (14:49 -0500)
We don't have to touch fbi->modelist in ldb_init(), because mxcfb_register()
may initialize the list and add a video mode to the list for us.

This patch fixes the following issue reported by Coverity:
INIT_LIST_HEAD(&fbi->modelist);
Uninitialized scalar variable (UNINIT)
uninit_use_in_call: Using uninitialized value fb_vm. Field fb_vm.name is
uninitialized when calling fb_add_videomode.
fb_add_videomode(&fb_vm, &fbi->modelist);
fb_videomode_to_var(&fbi->var, &fb_vm);

Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
drivers/video/fbdev/mxc/ldb.c

index e5716cb..1d6c9e0 100644 (file)
@@ -323,9 +323,6 @@ static int ldb_init(struct mxc_dispdrv_handle *mddh,
        chan->fbi = fbi;
 
        fb_videomode_from_videomode(&chan->vm, &fb_vm);
-
-       INIT_LIST_HEAD(&fbi->modelist);
-       fb_add_videomode(&fb_vm, &fbi->modelist);
        fb_videomode_to_var(&fbi->var, &fb_vm);
 
        setting->crtc = chan->crtc;