ath: Remove unnecessary ath_bcast_mac and use eth_broadcast_addr
authorJoe Perches <joe@perches.com>
Wed, 21 Mar 2018 10:32:52 +0000 (03:32 -0700)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 29 Mar 2018 09:10:26 +0000 (12:10 +0300)
Remove the static array and use the generic routine to set the
Ethernet broadcast address.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath.h
drivers/net/wireless/ath/ath5k/attach.c
drivers/net/wireless/ath/ath9k/htc_drv_init.c
drivers/net/wireless/ath/ath9k/init.c

index f3f2784..7a364ec 100644 (file)
@@ -33,8 +33,6 @@
  */
 #define        ATH_KEYMAX              128     /* max key cache size we handle */
 
-static const u8 ath_bcast_mac[ETH_ALEN] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
-
 struct ath_ani {
        bool caldone;
        unsigned int longcal_timer;
index 233054b..12d3a6c 100644 (file)
@@ -327,7 +327,7 @@ int ath5k_hw_init(struct ath5k_hw *ah)
        ath5k_hw_set_lladdr(ah, zero_mac);
 
        /* Set BSSID to bcast address: ff:ff:ff:ff:ff:ff for now */
-       memcpy(common->curbssid, ath_bcast_mac, ETH_ALEN);
+       eth_broadcast_addr(common->curbssid);
        ath5k_hw_set_bssid(ah);
        ath5k_hw_set_opmode(ah, ah->opmode);
 
index f246e9e..214c682 100644 (file)
@@ -591,7 +591,7 @@ static void ath9k_init_misc(struct ath9k_htc_priv *priv)
 {
        struct ath_common *common = ath9k_hw_common(priv->ah);
 
-       memcpy(common->bssidmask, ath_bcast_mac, ETH_ALEN);
+       eth_broadcast_addr(common->bssidmask);
 
        common->last_rssi = ATH_RSSI_DUMMY_MARKER;
        priv->ah->opmode = NL80211_IFTYPE_STATION;
index b71b167..c070a9e 100644 (file)
@@ -428,7 +428,7 @@ static void ath9k_init_misc(struct ath_softc *sc)
        timer_setup(&common->ani.timer, ath_ani_calibrate, 0);
 
        common->last_rssi = ATH_RSSI_DUMMY_MARKER;
-       memcpy(common->bssidmask, ath_bcast_mac, ETH_ALEN);
+       eth_broadcast_addr(common->bssidmask);
        sc->beacon.slottime = 9;
 
        for (i = 0; i < ARRAY_SIZE(sc->beacon.bslot); i++)