projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
188b121
)
dm9000: NULL dereferences on error in probe()
author
Dan Carpenter
<dan.carpenter@oracle.com>
Fri, 1 Aug 2014 08:23:57 +0000
(11:23 +0300)
committer
David S. Miller
<davem@davemloft.net>
Sat, 2 Aug 2014 22:28:23 +0000
(15:28 -0700)
The dm9000_release_board() function is called with NULL ->data_req and
->addr_req pointers if dm9000_probe() fails.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/davicom/dm9000.c
patch
|
blob
|
history
diff --git
a/drivers/net/ethernet/davicom/dm9000.c
b/drivers/net/ethernet/davicom/dm9000.c
index
13723c9
..
23084fb
100644
(file)
--- a/
drivers/net/ethernet/davicom/dm9000.c
+++ b/
drivers/net/ethernet/davicom/dm9000.c
@@
-817,10
+817,12
@@
dm9000_release_board(struct platform_device *pdev, struct board_info *db)
/* release the resources */
- release_resource(db->data_req);
+ if (db->data_req)
+ release_resource(db->data_req);
kfree(db->data_req);
- release_resource(db->addr_req);
+ if (db->addr_req)
+ release_resource(db->addr_req);
kfree(db->addr_req);
}