platform/chrome: wilco_ec: Add newlines to printks

printk messages all require newlines, or it looks very odd in the log
when messages are not on different lines. Add them.

Cc: Nick Crews <ncrews@chromium.org>
Cc: Daniel Campello <campello@chromium.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

diff --git a/drivers/platform/chrome/wilco_ec/core.c b/drivers/platform/chrome/wilco_ec/core.c
index 2d5f027..5b42992 100644 (file)
--- a/drivers/platform/chrome/wilco_ec/core.c
+++ b/drivers/platform/chrome/wilco_ec/core.c
@@ -94,7 +94,7 @@ static int wilco_ec_probe(struct platform_device *pdev)
 
        ret = wilco_ec_add_sysfs(ec);
        if (ret < 0) {
-               dev_err(dev, "Failed to create sysfs entries: %d", ret);
+               dev_err(dev, "Failed to create sysfs entries: %d\n", ret);
                goto unregister_rtc;
        }
 

diff --git a/drivers/platform/chrome/wilco_ec/keyboard_leds.c b/drivers/platform/chrome/wilco_ec/keyboard_leds.c
index 5731d1b..6ce9c67 100644 (file)
--- a/drivers/platform/chrome/wilco_ec/keyboard_leds.c
+++ b/drivers/platform/chrome/wilco_ec/keyboard_leds.c
@@ -69,7 +69,7 @@ static int send_kbbl_msg(struct wilco_ec_device *ec,
        ret = wilco_ec_mailbox(ec, &msg);
        if (ret < 0) {
                dev_err(ec->dev,
-                       "Failed sending keyboard LEDs command: %d", ret);
+                       "Failed sending keyboard LEDs command: %d\n", ret);
                return ret;
        }
 
@@ -94,7 +94,7 @@ static int set_kbbl(struct wilco_ec_device *ec, enum led_brightness brightness)
 
        if (response.status) {
                dev_err(ec->dev,
-                       "EC reported failure sending keyboard LEDs command: %d",
+                       "EC reported failure sending keyboard LEDs command: %d\n",
                        response.status);
                return -EIO;
        }
@@ -147,7 +147,7 @@ static int kbbl_init(struct wilco_ec_device *ec)
 
        if (response.status) {
                dev_err(ec->dev,
-                       "EC reported failure sending keyboard LEDs command: %d",
+                       "EC reported failure sending keyboard LEDs command: %d\n",
                        response.status);
                return -EIO;
        }
@@ -179,7 +179,7 @@ int wilco_keyboard_leds_init(struct wilco_ec_device *ec)
        ret = kbbl_exist(ec, &leds_exist);
        if (ret < 0) {
                dev_err(ec->dev,
-                       "Failed checking keyboard LEDs support: %d", ret);
+                       "Failed checking keyboard LEDs support: %d\n", ret);
                return ret;
        }
        if (!leds_exist)

diff --git a/drivers/platform/chrome/wilco_ec/mailbox.c b/drivers/platform/chrome/wilco_ec/mailbox.c
index ced1f9f..0f98358 100644 (file)
--- a/drivers/platform/chrome/wilco_ec/mailbox.c
+++ b/drivers/platform/chrome/wilco_ec/mailbox.c
@@ -163,13 +163,13 @@ static int wilco_ec_transfer(struct wilco_ec_device *ec,
        }
 
        if (rs->data_size != EC_MAILBOX_DATA_SIZE) {
-               dev_dbg(ec->dev, "unexpected packet size (%u != %u)",
+               dev_dbg(ec->dev, "unexpected packet size (%u != %u)\n",
                        rs->data_size, EC_MAILBOX_DATA_SIZE);
                return -EMSGSIZE;
        }
 
        if (rs->data_size < msg->response_size) {
-               dev_dbg(ec->dev, "EC didn't return enough data (%u < %zu)",
+               dev_dbg(ec->dev, "EC didn't return enough data (%u < %zu)\n",
                        rs->data_size, msg->response_size);
                return -EMSGSIZE;
        }

diff --git a/drivers/platform/chrome/wilco_ec/telemetry.c b/drivers/platform/chrome/wilco_ec/telemetry.c
index 1176d54..e06d96f 100644 (file)
--- a/drivers/platform/chrome/wilco_ec/telemetry.c
+++ b/drivers/platform/chrome/wilco_ec/telemetry.c
@@ -367,7 +367,7 @@ static int telem_device_probe(struct platform_device *pdev)
        minor = ida_alloc_max(&telem_ida, TELEM_MAX_DEV-1, GFP_KERNEL);
        if (minor < 0) {
                error = minor;
-               dev_err(&pdev->dev, "Failed to find minor number: %d", error);
+               dev_err(&pdev->dev, "Failed to find minor number: %d\n", error);
                return error;
        }
 
@@ -427,14 +427,14 @@ static int __init telem_module_init(void)
 
        ret = class_register(&telem_class);
        if (ret) {
-               pr_err(DRV_NAME ": Failed registering class: %d", ret);
+               pr_err(DRV_NAME ": Failed registering class: %d\n", ret);
                return ret;
        }
 
        /* Request the kernel for device numbers, starting with minor=0 */
        ret = alloc_chrdev_region(&dev_num, 0, TELEM_MAX_DEV, TELEM_DEV_NAME);
        if (ret) {
-               pr_err(DRV_NAME ": Failed allocating dev numbers: %d", ret);
+               pr_err(DRV_NAME ": Failed allocating dev numbers: %d\n", ret);
                goto destroy_class;
        }
        telem_major = MAJOR(dev_num);