projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a3888f6
)
mfd: mt6397: Do not call irq_domain_remove if PMIC unsupported
author
Nicolas Boichat
<drinkcat@chromium.org>
Mon, 22 Oct 2018 02:55:06 +0000
(10:55 +0800)
committer
Lee Jones
<lee.jones@linaro.org>
Thu, 3 Jan 2019 08:32:42 +0000
(08:32 +0000)
If the PMIC ID is unknown, the current code would call
irq_domain_remove and panic, as pmic->irq_domain is only
initialized by mt6397_irq_init.
Return immediately with an error, if the chip ID is unsupported.
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/mt6397-core.c
patch
|
blob
|
history
diff --git
a/drivers/mfd/mt6397-core.c
b/drivers/mfd/mt6397-core.c
index
77b64bd
..
ab24e17
100644
(file)
--- a/
drivers/mfd/mt6397-core.c
+++ b/
drivers/mfd/mt6397-core.c
@@
-329,8
+329,7
@@
static int mt6397_probe(struct platform_device *pdev)
default:
dev_err(&pdev->dev, "unsupported chip: %d\n", id);
- ret = -ENODEV;
- break;
+ return -ENODEV;
}
if (ret) {