scsi: myrb: Make some symblos static
authorJason Yan <yanaijie@huawei.com>
Tue, 15 Sep 2020 08:40:18 +0000 (16:40 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 16 Sep 2020 01:32:01 +0000 (21:32 -0400)
This addresses the following sparse warning:

drivers/scsi/myrb.c:2229:27: warning: symbol 'myrb_template' was not
declared. Should it be static?
drivers/scsi/myrb.c:2318:31: warning: symbol 'myrb_raid_functions' was
not declared. Should it be static?
drivers/scsi/myrb.c:2492:6: warning: symbol 'myrb_err_status' was not
declared. Should it be static?

Link: https://lore.kernel.org/r/20200915084018.2826922-1-yanaijie@huawei.com
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/myrb.c

index d4bd31a..b8020ea 100644 (file)
@@ -2226,7 +2226,7 @@ static struct device_attribute *myrb_shost_attrs[] = {
        NULL,
 };
 
-struct scsi_host_template myrb_template = {
+static struct scsi_host_template myrb_template = {
        .module                 = THIS_MODULE,
        .name                   = "DAC960",
        .proc_name              = "myrb",
@@ -2315,7 +2315,7 @@ static void myrb_get_state(struct device *dev)
        raid_set_state(myrb_raid_template, dev, state);
 }
 
-struct raid_function_template myrb_raid_functions = {
+static struct raid_function_template myrb_raid_functions = {
        .cookie         = &myrb_template,
        .is_raid        = myrb_is_raid,
        .get_resync     = myrb_get_resync,
@@ -2489,7 +2489,7 @@ static void myrb_monitor(struct work_struct *work)
  *
  * Return: true for fatal errors and false otherwise.
  */
-bool myrb_err_status(struct myrb_hba *cb, unsigned char error,
+static bool myrb_err_status(struct myrb_hba *cb, unsigned char error,
                unsigned char parm0, unsigned char parm1)
 {
        struct pci_dev *pdev = cb->pdev;