LFU-18 spi: fsl_lpspi: Fix dereference before null check
authorYe Li <ye.li@nxp.com>
Thu, 27 May 2021 08:05:44 +0000 (01:05 -0700)
committerYe Li <ye.li@nxp.com>
Thu, 27 May 2021 12:02:34 +0000 (05:02 -0700)
Fix coverity Issue: 11026161 Dereference before null check
The lpspi should not be dereferenced before null checking, moving
getting its udevice after the checking

Signed-off-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
drivers/spi/fsl_lpspi.c

index 9c67f1a..7870b27 100644 (file)
@@ -300,13 +300,15 @@ static int fsl_lpspi_xfer_internal(struct fsl_lpspi_slave *lpspi,
        u32 blk_size;
        struct LPSPI_Type *regs;
        u8 watermark = 0;
-       struct udevice *dev = lpspi->dev;
-       struct dm_spi_slave_plat *slave_plat = dev_get_parent_plat(dev);
+       struct udevice *dev;
+       struct dm_spi_slave_plat *slave_plat;
 
        if (!lpspi)
                return -EINVAL;
 
        regs = (struct LPSPI_Type *)lpspi->base;
+       dev = lpspi->dev;
+       slave_plat = dev_get_parent_plat(dev);
 
        ret = fsl_lpspi_check_trans_len(n_bytes, lpspi->wordlen);
        if (ret)