Revert "mtd: spi-nor: Prefer asynchronous probe"
authorVignesh Raghavendra <vigneshr@ti.com>
Mon, 5 Oct 2020 08:55:10 +0000 (14:25 +0530)
committerVignesh Raghavendra <vigneshr@ti.com>
Tue, 6 Oct 2020 05:16:07 +0000 (10:46 +0530)
This reverts commit 03edda0e1edaa3c2e99239c66e3c14d749318fd6.

This leads to warn dump like [1] on some platforms and reorders MTD
devices which may break user space expectations [2]. So revert the change.

[1]:

[    1.849801] ------------[ cut here ]------------
[    1.854271] mscc_felix 0000:00:00.5: device is disabled, skipping
[    1.858753] WARNING: CPU: 1 PID: 7 at kernel/kmod.c:136 __request_module+0x3a4/0x568

[...]

[2] Bug report: https://lore.kernel.org/linux-mtd/20201003150633.23416-1-michael@walle.cc/

Reported-by: Michael Walle <michael@walle.cc>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20201005090321.8724-1-vigneshr@ti.com
drivers/mtd/spi-nor/core.c

index 2add4a0..0369d98 100644 (file)
@@ -3451,7 +3451,6 @@ static struct spi_mem_driver spi_nor_driver = {
                .driver = {
                        .name = "spi-nor",
                        .of_match_table = spi_nor_of_table,
-                       .probe_type = PROBE_PREFER_ASYNCHRONOUS,
                },
                .id_table = spi_nor_dev_ids,
        },