debugfs: Re-use kstrtobool_from_user()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 3 May 2018 16:17:52 +0000 (19:17 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 14 May 2018 14:48:18 +0000 (16:48 +0200)
Re-use kstrtobool_from_user() instead of open coded variant.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/debugfs/file.c

index 1f99678..4fce1da 100644 (file)
@@ -796,19 +796,13 @@ EXPORT_SYMBOL_GPL(debugfs_read_file_bool);
 ssize_t debugfs_write_file_bool(struct file *file, const char __user *user_buf,
                                size_t count, loff_t *ppos)
 {
-       char buf[32];
-       size_t buf_size;
        bool bv;
        int r;
        bool *val = file->private_data;
        struct dentry *dentry = F_DENTRY(file);
 
-       buf_size = min(count, (sizeof(buf)-1));
-       if (copy_from_user(buf, user_buf, buf_size))
-               return -EFAULT;
-
-       buf[buf_size] = '\0';
-       if (strtobool(buf, &bv) == 0) {
+       r = kstrtobool_from_user(user_buf, count, &bv);
+       if (!r) {
                r = debugfs_file_get(dentry);
                if (unlikely(r))
                        return r;