bnxt_en: Register buffers for VFs before reserving resources.
authorVasundhara Volam <vasundhara-v.volam@broadcom.com>
Fri, 30 Aug 2019 03:54:51 +0000 (23:54 -0400)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 Aug 2019 21:02:18 +0000 (14:02 -0700)
When VFs need to be reconfigured dynamically after firmwware reset, the
configuration sequence on the PF needs to be changed to register the VF
buffers first.  Otherwise, some VF firmware commands may not succeed as
there may not be PF buffers ready for the re-directed firmware commands.

This sequencing did not matter much before when we only supported
the normal bring-up of VFs.

Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c

index 7506d20..ac890ca 100644 (file)
@@ -671,6 +671,11 @@ int bnxt_cfg_hw_sriov(struct bnxt *bp, int *num_vfs)
 {
        int rc;
 
+       /* Register buffers for VFs */
+       rc = bnxt_hwrm_func_buf_rgtr(bp);
+       if (rc)
+               return rc;
+
        /* Reserve resources for VFs */
        rc = bnxt_func_cfg(bp, *num_vfs);
        if (rc != *num_vfs) {
@@ -684,11 +689,6 @@ int bnxt_cfg_hw_sriov(struct bnxt *bp, int *num_vfs)
                *num_vfs = rc;
        }
 
-       /* Register buffers for VFs */
-       rc = bnxt_hwrm_func_buf_rgtr(bp);
-       if (rc)
-               return rc;
-
        bnxt_ulp_sriov_cfg(bp, *num_vfs);
        return 0;
 }