crypto/morus(640,1280) - make crypto_...-algs static
authorvaldis.kletnieks@vt.edu <valdis.kletnieks@vt.edu>
Wed, 26 Sep 2018 22:49:38 +0000 (18:49 -0400)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 5 Oct 2018 02:22:48 +0000 (10:22 +0800)
sparse complains thusly:

  CHECK   arch/x86/crypto/morus640-sse2-glue.c
arch/x86/crypto/morus640-sse2-glue.c:38:1: warning: symbol 'crypto_morus640_sse2_algs' was not declared. Should it be static?
  CHECK   arch/x86/crypto/morus1280-sse2-glue.c
arch/x86/crypto/morus1280-sse2-glue.c:38:1: warning: symbol 'crypto_morus1280_sse2_algs' was not declared. Should it be static?
  CHECK   arch/x86/crypto/morus1280-avx2-glue.c
arch/x86/crypto/morus1280-avx2-glue.c:38:1: warning: symbol 'crypto_morus1280_avx2_algs' was not declared. Should it be static?

and sparse is correct - these don't need to be global and polluting the namespace.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Acked-by: Ondrej Mosnacek <omosnacek@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
include/crypto/morus1280_glue.h
include/crypto/morus640_glue.h

index b26dd70..ba782e1 100644 (file)
@@ -82,7 +82,7 @@ void cryptd_morus1280_glue_exit_tfm(struct crypto_aead *aead);
        { \
        } \
        \
-       struct aead_alg crypto_morus1280_##id##_algs[] = {\
+       static struct aead_alg crypto_morus1280_##id##_algs[] = {\
                { \
                        .setkey = crypto_morus1280_glue_setkey, \
                        .setauthsize = crypto_morus1280_glue_setauthsize, \
index 90c8db0..27fa790 100644 (file)
@@ -82,7 +82,7 @@ void cryptd_morus640_glue_exit_tfm(struct crypto_aead *aead);
        { \
        } \
        \
-       struct aead_alg crypto_morus640_##id##_algs[] = {\
+       static struct aead_alg crypto_morus640_##id##_algs[] = {\
                { \
                        .setkey = crypto_morus640_glue_setkey, \
                        .setauthsize = crypto_morus640_glue_setauthsize, \