net: ena: ethtool: remove redundant non-zero check on rc
authorColin Ian King <colin.king@canonical.com>
Fri, 21 Feb 2020 23:26:53 +0000 (23:26 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 Feb 2020 00:40:38 +0000 (16:40 -0800)
The non-zero check on rc is redundant as a previous non-zero
check on rc will always return and the second check is never
reached, hence it is redundant and can be removed.  Also
remove a blank line.

Addresses-Coverity: ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/amazon/ena/ena_ethtool.c

index ced1d57..1e38930 100644 (file)
@@ -674,7 +674,6 @@ static int ena_get_rxfh(struct net_device *netdev, u32 *indir, u8 *key,
         * supports getting/setting the hash function.
         */
        rc = ena_com_get_hash_function(adapter->ena_dev, &ena_func, key);
-
        if (rc) {
                if (rc == -EOPNOTSUPP) {
                        key = NULL;
@@ -685,9 +684,6 @@ static int ena_get_rxfh(struct net_device *netdev, u32 *indir, u8 *key,
                return rc;
        }
 
-       if (rc)
-               return rc;
-
        switch (ena_func) {
        case ENA_ADMIN_TOEPLITZ:
                func = ETH_RSS_HASH_TOP;