sctp: Add missing annotation for sctp_err_finish()
authorJules Irenge <jbi.octave@gmail.com>
Sun, 23 Feb 2020 23:16:45 +0000 (23:16 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 Feb 2020 21:26:48 +0000 (13:26 -0800)
Sparse reports a warning at sctp_err_finish()
warning: context imbalance in sctp_err_finish() - unexpected unlock

The root cause is a missing annotation at sctp_err_finish()
Add the missing  __releases(&((__sk)->sk_lock.slock)) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/input.c

index efaaefc..55d4fc6 100644 (file)
@@ -548,6 +548,7 @@ out:
 
 /* Common cleanup code for icmp/icmpv6 error handler. */
 void sctp_err_finish(struct sock *sk, struct sctp_transport *t)
+       __releases(&((__sk)->sk_lock.slock))
 {
        bh_unlock_sock(sk);
        sctp_transport_put(t);