mailbox: altera: Use device-managed registration API
authorThierry Reding <treding@nvidia.com>
Thu, 20 Dec 2018 17:19:52 +0000 (18:19 +0100)
committerJassi Brar <jaswinder.singh@linaro.org>
Fri, 21 Dec 2018 22:49:25 +0000 (16:49 -0600)
Get rid of some boilerplate driver removal code by using the newly added
device-managed registration API.

Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/mailbox-altera.c

index bcb29df..397e25d 100644 (file)
@@ -341,7 +341,7 @@ static int altera_mbox_probe(struct platform_device *pdev)
                }
        }
 
-       ret = mbox_controller_register(&mbox->controller);
+       ret = devm_mbox_controller_register(&pdev->dev, &mbox->controller);
        if (ret) {
                dev_err(&pdev->dev, "Register mailbox failed\n");
                goto err;
@@ -352,18 +352,6 @@ err:
        return ret;
 }
 
-static int altera_mbox_remove(struct platform_device *pdev)
-{
-       struct altera_mbox *mbox = platform_get_drvdata(pdev);
-
-       if (!mbox)
-               return -EINVAL;
-
-       mbox_controller_unregister(&mbox->controller);
-
-       return 0;
-}
-
 static const struct of_device_id altera_mbox_match[] = {
        { .compatible = "altr,mailbox-1.0" },
        { /* Sentinel */ }
@@ -373,7 +361,6 @@ MODULE_DEVICE_TABLE(of, altera_mbox_match);
 
 static struct platform_driver altera_mbox_driver = {
        .probe  = altera_mbox_probe,
-       .remove = altera_mbox_remove,
        .driver = {
                .name   = DRIVER_NAME,
                .of_match_table = altera_mbox_match,