tracing: Fix synthetic print fmt check for use of __get_str()
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Wed, 7 Oct 2020 14:34:34 +0000 (10:34 -0400)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Thu, 8 Oct 2020 19:29:07 +0000 (15:29 -0400)
A cut and paste error had the check to use __get_str() test "is_dynamic"
twice, instead of checking "is_string && is_dynamic".

Link: https://lore.kernel.org/r/d34dccd5-96ba-a2d9-46ea-de8807525deb@canonical.com
Reported-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Tom Zanussi <zanussi@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_events_synth.c

index 742ce5f..3b2dcc4 100644 (file)
@@ -491,7 +491,7 @@ static int __set_synth_event_print_fmt(struct synth_event *event,
        pos += snprintf(buf + pos, LEN_OR_ZERO, "\"");
 
        for (i = 0; i < event->n_fields; i++) {
-               if (event->fields[i]->is_dynamic &&
+               if (event->fields[i]->is_string &&
                    event->fields[i]->is_dynamic)
                        pos += snprintf(buf + pos, LEN_OR_ZERO,
                                ", __get_str(%s)", event->fields[i]->name);