pwm: rockchip: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 26 Aug 2020 14:47:44 +0000 (16:47 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 24 Sep 2020 07:18:10 +0000 (09:18 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-rockchip.c

index 098e943..77c23a2 100644 (file)
@@ -307,13 +307,9 @@ static int rockchip_pwm_probe(struct platform_device *pdev)
        pc->clk = devm_clk_get(&pdev->dev, "pwm");
        if (IS_ERR(pc->clk)) {
                pc->clk = devm_clk_get(&pdev->dev, NULL);
-               if (IS_ERR(pc->clk)) {
-                       ret = PTR_ERR(pc->clk);
-                       if (ret != -EPROBE_DEFER)
-                               dev_err(&pdev->dev, "Can't get bus clk: %d\n",
-                                       ret);
-                       return ret;
-               }
+               if (IS_ERR(pc->clk))
+                       return dev_err_probe(&pdev->dev, PTR_ERR(pc->clk),
+                                            "Can't get bus clk\n");
        }
 
        count = of_count_phandle_with_args(pdev->dev.of_node,