USB: legousbtower: drop noisy disconnect messages
authorJohan Hovold <johan@kernel.org>
Tue, 5 Nov 2019 08:41:43 +0000 (09:41 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 7 Nov 2019 10:17:50 +0000 (11:17 +0100)
User space already sees -ENODEV in case it tries to do I/O post
disconnect, no need to spam the logs with printk messages that don't
even include any device-id information.

Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191105084152.16322-6-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/legousbtower.c

index 1626a0d..937bce2 100644 (file)
@@ -540,7 +540,6 @@ static ssize_t tower_read (struct file *file, char __user *buffer, size_t count,
        /* verify that the device wasn't unplugged */
        if (dev->disconnected) {
                retval = -ENODEV;
-               pr_err("No device or device unplugged %d\n", retval);
                goto unlock_exit;
        }
 
@@ -626,7 +625,6 @@ static ssize_t tower_write (struct file *file, const char __user *buffer, size_t
        /* verify that the device wasn't unplugged */
        if (dev->disconnected) {
                retval = -ENODEV;
-               pr_err("No device or device unplugged %d\n", retval);
                goto unlock_exit;
        }