net: Queue net_cleanup_work only if there is first net added
authorKirill Tkhai <ktkhai@virtuozzo.com>
Mon, 19 Feb 2018 09:58:54 +0000 (12:58 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 20 Feb 2018 18:23:49 +0000 (13:23 -0500)
When llist_add() returns false, cleanup_net() hasn't made its
llist_del_all(), while the work has already been scheduled
by the first queuer. So, we may skip queue_work() in this case.

Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/net_namespace.c

index abf8a46..27a5523 100644 (file)
@@ -582,8 +582,8 @@ static DECLARE_WORK(net_cleanup_work, cleanup_net);
 void __put_net(struct net *net)
 {
        /* Cleanup the network namespace in process context */
-       llist_add(&net->cleanup_list, &cleanup_list);
-       queue_work(netns_wq, &net_cleanup_work);
+       if (llist_add(&net->cleanup_list, &cleanup_list))
+               queue_work(netns_wq, &net_cleanup_work);
 }
 EXPORT_SYMBOL_GPL(__put_net);