NFSv4: Fix the alignment of page data in the getdeviceinfo reply
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Sat, 14 Nov 2020 02:42:16 +0000 (21:42 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:53:30 +0000 (11:53 +0100)
[ Upstream commit 046e5ccb4198b990190e11fb52fd9cfd264402eb ]

We can fit the device_addr4 opaque data padding in the pages.

Fixes: cf500bac8fd4 ("SUNRPC: Introduce rpc_prepare_reply_pages()")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/nfs/nfs4xdr.c

index c6dbfca..c16b93d 100644 (file)
@@ -3009,15 +3009,19 @@ static void nfs4_xdr_enc_getdeviceinfo(struct rpc_rqst *req,
        struct compound_hdr hdr = {
                .minorversion = nfs4_xdr_minorversion(&args->seq_args),
        };
+       uint32_t replen;
 
        encode_compound_hdr(xdr, req, &hdr);
        encode_sequence(xdr, &args->seq_args, &hdr);
+
+       replen = hdr.replen + op_decode_hdr_maxsz;
+
        encode_getdeviceinfo(xdr, args, &hdr);
 
-       /* set up reply kvec. Subtract notification bitmap max size (2)
-        * so that notification bitmap is put in xdr_buf tail */
+       /* set up reply kvec. device_addr4 opaque data is read into the
+        * pages */
        rpc_prepare_reply_pages(req, args->pdev->pages, args->pdev->pgbase,
-                               args->pdev->pglen, hdr.replen - 2);
+                               args->pdev->pglen, replen + 2 + 1);
        encode_nops(&hdr);
 }