clk: s2mps11: Fix a resource leak in error handling paths in the probe function
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 12 Dec 2020 12:28:18 +0000 (13:28 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:54:01 +0000 (11:54 +0100)
[ Upstream commit d2d94fc567624f96187e8b52083795620f93e69f ]

Some resource should be released in the error handling path of the probe
function, as already done in the remove function.

The remove function was fixed in commit bf416bd45738 ("clk: s2mps11: Add
missing of_node_put and of_clk_del_provider")

Fixes: 7cc560dea415 ("clk: s2mps11: Add support for s2mps11")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/20201212122818.86195-1-christophe.jaillet@wanadoo.fr
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/clk-s2mps11.c

index aa21371..a3e883a 100644 (file)
@@ -195,6 +195,7 @@ static int s2mps11_clk_probe(struct platform_device *pdev)
        return ret;
 
 err_reg:
+       of_node_put(s2mps11_clks[0].clk_np);
        while (--i >= 0)
                clkdev_drop(s2mps11_clks[i].lookup);