drm: Shift wrap bug in create_in_format_blob()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 9 Aug 2017 11:19:06 +0000 (14:19 +0300)
committerNitin Garg <nitin.garg@nxp.com>
Tue, 20 Mar 2018 19:52:04 +0000 (14:52 -0500)
"plane->format_count" can go up to 64.  (It's capped in
drm_universal_plane_init().)  So we should be using ULL type instead of
int here to prevent shift wrapping.

Fixes: db1689aa61bd ("drm: Create a format/modifier blob")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20170809111906.4rv3hzritctfktv3@mwanda
(cherry picked from commit aadd41485bb227a16f964833a4fd55c091f4a729)

drivers/gpu/drm/drm_plane.c

index 1020388..a8e9c85 100644 (file)
@@ -126,7 +126,7 @@ static int create_in_format_blob(struct drm_device *dev, struct drm_plane *plane
                                                               plane->format_types[j],
                                                               plane->modifiers[i])) {
 
-                               mod->formats |= 1 << j;
+                               mod->formats |= 1ULL << j;
                        }
                }