projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a9b8398
)
scsi: aic7xxx: Fix error code handling
author
Tong Zhang
<ztong0001@gmail.com>
Sun, 16 Aug 2020 07:02:42 +0000
(
03:02
-0400)
committer
Martin K. Petersen
<martin.petersen@oracle.com>
Tue, 25 Aug 2020 03:13:27 +0000
(23:13 -0400)
ahc_linux_queue_recovery_cmd returns SUCCESS(0x2002) or FAIL(0x2003), but
the caller is checking error case using != 0.
Link:
https://lore.kernel.org/r/20200816070242.978839-1-ztong0001@gmail.com
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/aic7xxx/aic7xxx_osm.c
patch
|
blob
|
history
diff --git
a/drivers/scsi/aic7xxx/aic7xxx_osm.c
b/drivers/scsi/aic7xxx/aic7xxx_osm.c
index
e7ccb8b
..
7bba961
100644
(file)
--- a/
drivers/scsi/aic7xxx/aic7xxx_osm.c
+++ b/
drivers/scsi/aic7xxx/aic7xxx_osm.c
@@
-730,7
+730,7
@@
ahc_linux_abort(struct scsi_cmnd *cmd)
int error;
error = ahc_linux_queue_recovery_cmd(cmd, SCB_ABORT);
- if (error !=
0
)
+ if (error !=
SUCCESS
)
printk("aic7xxx_abort returns 0x%x\n", error);
return (error);
}
@@
-744,7
+744,7
@@
ahc_linux_dev_reset(struct scsi_cmnd *cmd)
int error;
error = ahc_linux_queue_recovery_cmd(cmd, SCB_DEVICE_RESET);
- if (error !=
0
)
+ if (error !=
SUCCESS
)
printk("aic7xxx_dev_reset returns 0x%x\n", error);
return (error);
}