gpio: mlxbf2: fix return value check in mlxbf2_gpio_get_lock_res()
authorWei Yongjun <weiyongjun1@huawei.com>
Mon, 27 Apr 2020 11:08:29 +0000 (11:08 +0000)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 28 Apr 2020 14:11:16 +0000 (16:11 +0200)
In case of error, the function devm_ioremap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20200427110829.154785-1-weiyongjun1@huawei.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-mlxbf2.c

index 240b488..fca6a50 100644 (file)
@@ -109,8 +109,8 @@ static int mlxbf2_gpio_get_lock_res(struct platform_device *pdev)
        }
 
        yu_arm_gpio_lock_param.io = devm_ioremap(dev, res->start, size);
-       if (IS_ERR(yu_arm_gpio_lock_param.io))
-               ret = PTR_ERR(yu_arm_gpio_lock_param.io);
+       if (!yu_arm_gpio_lock_param.io)
+               ret = -ENOMEM;
 
 exit:
        mutex_unlock(yu_arm_gpio_lock_param.lock);